Skip to main content
On this page

P2 · skill-* filesystem prefix — progress note (2026-05-21)

Status: SHIPPED (locally).

Commits

Text
2e50350 v4/P2-review-fix: wire LEGACY_GLOBAL_AREA into base_dir_for; trim comment6702041 v4/P2: skill-* filesystem prefix

Test pass count

321 passed (no regressions vs P1 baseline).

Exit-criteria check (plan §8 P2)

Criterion Evidence Status
All skill working dirs under skill-<name>/ _common.py:PR_REVIEW_ROOT, pr_task.py:PR_REVIEW_ROOT, adk_task_slug.py:GLOBAL_AREA all map to skill-<stem>/. ✓
Old paths return ENOENT after migration Read-shim falls back to legacy paths when present; the actual ENOENT half lands when P7’s data migration runs. Partial — P7 owns the data move; this is a staging decision documented in the commit msg.

What got done

  • v3 task-root names (pr-reviews/, investigations/, reviews/, sync/, setup/, improve/, explain/) → v4 names (skill-<stem>/).
  • Read-shim implemented in 3 places: _common.task_dir_for, pr_task._resolve_pr_review_root, adk_task_slug.base_dir_for. All prefer the v4 path and fall back to the legacy path only when the legacy dir exists on disk.
  • ~/.agents-devkit/improve/ (top-level shared learning state per §3 architecture) — preserved as a separate dir; only the per-task skill-improve/<ts>/ directory follows the new naming.
  • All user-visible doc strings updated (README.md, shared/paths.md, workflow docs, validate_findings.py help).
  • .gitignore extended to exclude .claude/worktrees/ so agent worktrees don’t leak into commits.

What got skipped (and why)

  • Live filesystem migration of ~/.agents-devkit/pr-reviews/ → skill-pr-review/ — out of scope for P2. The plan §8 P7 owns the data move. Read-shim preserves in-flight task folders until P7 runs.
  • Removal of empty memory/ — likewise P7 owns it.
  • queue_io.LEGACY_QUEUE_PATH deletion — deliberately kept as a back-compat fallback; the alias migration in queue_io is part of P1, not P2.

Decisions made this run

  • improve/ (top-level data dir) stays; only per-task artifacts go under skill-improve/<ts>/. Per plan §3 architecture; auto-defaulted (no user prompt needed).
  • Read-shim direction: prefer v4 path. Auto-defaulted (the plan §7 “preservation contract” implies migration is forward-only).
  • Worker isolation: skipped for P2 because the work is mechanical and small (single-implementer would have stalled like W2 did). Worked in cwd directly with sed-style mechanical edits.

Code review verdict

After fix: PASS — P2 ships (one critical found by reviewer, addressed in 2e50350).

Exact commands to inspect

Shell
git log --oneline 6702041^..2e50350         # 2 commitsgit show 6702041 --stat                      # what landed in P2git diff 6702041..2e50350                    # the review fixpython3 -m pytest skills/adk-cli/scripts/tests/ skills/adk-pr-review/scripts/tests/ -q